Skip to content

feat: add tests for dependency / package management#708

Open
jakelorocco wants to merge 1 commit intomainfrom
jal/package-tests
Open

feat: add tests for dependency / package management#708
jakelorocco wants to merge 1 commit intomainfrom
jal/package-tests

Conversation

@jakelorocco
Copy link
Contributor

@jakelorocco jakelorocco commented Mar 19, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue: Fixes N/A

Adds a series of tests to address issues we had previously seen with imports / dependencies. The tests:

  • ensure that only packages associated with a dependency group (like hf / litellm) are imported by their relevant module / file
  • ensure that new dependency groups get new tests added
  • ensure that Mellea import time doesn't grow beyond 750ms (we can refine this number, but I'm unsure how stable it is on github action runners)

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Mar 19, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@jakelorocco jakelorocco force-pushed the jal/package-tests branch 3 times, most recently from 1fbaaf1 to 95112e5 Compare March 19, 2026 19:34
@jakelorocco jakelorocco marked this pull request as ready for review March 19, 2026 20:19
@jakelorocco jakelorocco requested a review from a team as a code owner March 19, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant