Skip to content

Conversation

@jakelorocco
Copy link
Contributor

@jakelorocco jakelorocco commented Jan 16, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

Move rich document imports so that they aren't imported by default.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@jakelorocco jakelorocco force-pushed the jal/fix-bookmark-times branch from d9474df to ef34bad Compare January 16, 2026 14:32
@mergify
Copy link

mergify bot commented Jan 16, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@nrfulton
Copy link
Contributor

main:

(.venv) nathan@macbookpro:~/dev/mellea$ time python3 -c "import mellea"

real	0m4.102s
user	0m3.773s
sys	0m2.605s

this branch:

(.venv) nathan@macbookpro:~/dev/mellea$ time python3 -c "import mellea"

real	0m0.267s
user	0m0.192s
sys	0m0.061s

lgtm 🚀

@jakelorocco jakelorocco force-pushed the jal/fix-bookmark-times branch from ef34bad to 0d18c59 Compare January 16, 2026 14:49
@jakelorocco jakelorocco marked this pull request as ready for review January 16, 2026 15:08
@jakelorocco jakelorocco merged commit 565b27f into main Jan 16, 2026
7 checks passed
@jakelorocco jakelorocco deleted the jal/fix-bookmark-times branch January 16, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants