blog: Qiskit IVR functional validation#47
Open
ajbozarth wants to merge 1 commit into
Open
Conversation
Contributor
Author
ajbozarth
force-pushed
the
docs/qiskit-ivr-functional-validation
branch
from
46613d8 to
a3fe774
Compare
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
ajbozarth
force-pushed
the
docs/qiskit-ivr-functional-validation
branch
from
a3fe774 to
eb50af3
Compare
planetf1
reviewed
May 18, 2026
Collaborator
planetf1
left a comment
planetf1
left a comment
There was a problem hiding this comment.
Nice follow-up to the first IVR post. The strategy-flip under richer feedback caught my attention, and the scope-honesty section about what does and doesn't transfer lands well. One small adapter-experience note inline.
| exec(code, namespace) | ||
| fn = namespace[entry_point] | ||
| exec(check_fn, namespace) | ||
| namespace["check"](fn) |
Collaborator
There was a problem hiding this comment.
The namespace["check"] key is hardcoded. QHE's per-problem tests all happen to be named check, so this works for the benchmark as written. The prose later in the post invites readers to plug in their own test suites, and anyone who does will hit a KeyError unless their function is also named check. One inline note in the snippet would save them the debug session.
Suggested change
| namespace["check"](fn) | |
| namespace["check"](fn) # QHE tests are named "check"; change to match yours |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check()into the IVR loop as a second validator alongside QKTthe same 302-run benchmark
check()validator is dataset-bound, but the integration pattern transfers to any project's tests
Test plan
npm run lint:mdcleannpm run dev/blogs/qiskit-ivr-code-validation/resolves