Development #19
Merged
Development #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| private static string[] excludeHeaderBase = [ |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix this issue, the excludeHeaderBase field declaration at line 133 should be changed from:
private static string[] excludeHeaderBase = [
"Set-Cookie", // Handled seperately
"transfer-encoding" // Can break data transfer
];to:
private static readonly string[] excludeHeaderBase = [
"Set-Cookie", // Handled seperately
"transfer-encoding" // Can break data transfer
];This ensures the reference to the array cannot be re-assigned after static initialization, which is what the CodeQL warning is requesting. No additional imports or methods are needed. No other code needs to change, as the usage of excludeHeaderBase is not shown to involve reassignment.
Suggested changeset
1
src/Gemstone.Web/WebExtensions.cs
| @@ -130,7 +130,7 @@ | ||
| return; | ||
| } | ||
|
|
||
| private static string[] excludeHeaderBase = [ | ||
| private static readonly string[] excludeHeaderBase = [ | ||
| "Set-Cookie", // Handled seperately | ||
| "transfer-encoding" // Can break data transfer | ||
| ]; |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.