chore(schema): allow string-valued issue/volume in citation references#37
Merged
Merged
Conversation
Some Gems & Gemology entries cite combined issues (e.g. "1–4") which can't be expressed as integers. Widen the journal-reference Zod schema to accept either int or string for volume and issue. Unblocks the v1.3.0 content sync (gemmology-knowledge equipment/conoscope.yaml declares issue: "1–4" against Read 2014 chapter range).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
journalReferenceSchemainsrc/content/config.tsto accept eitherz.number().int()orz.string()for bothvolumeandissue.gemmology-knowledge:equipment/conoscope.yamlreferences Read (2014) withissue: "1–4"(a legitimate combined-issue range from Gemmology chapter citations) which Astro's content collection validator was rejecting withExpected type "number", received "string".Background
After WA1+WA2+WA5 merged in
gemmology-knowledgeand v1.3.0 was tagged,npm run buildfailed schema validation onequipment/conoscope.yamlandphenomena/asterism.yaml. The cleanest fix is to widen the Zod schema; string-valued issues are valid in CSL-JSON and Gems & Gemology routinely publishes combined issues.Test plan
npm run syncsucceeds (138 files)npm run validate:citationsreports 0 errors / 0 warningsnpm run buildcompletes with 913 pages and no schema errors