Skip to content

fix!: use gridUrl: "local" by default #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KuznetsovRoman wants to merge 1 commit into
base: testplane@9
Choose a base branch
from
Open

fix!: use gridUrl: "local" by default #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/browser/new-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
} from "../constants/config";
import { Config } from "../config";
import { BrowserConfig } from "../config/browser-config";
import { gridUrl as DEFAULT_GRID_URL } from "../config/defaults";
import { BrowserName, type W3CBrowserName } from "./types";

export type VendorSpecificCapabilityName = "goog:chromeOptions" | "moz:firefoxOptions" | "ms:edgeOptions";
Expand Down Expand Up @@ -151,7 +150,7 @@ export class NewBrowser extends Browser {
} else {
// if automationProtocol is not "webdriver", fallback to default grid url from "local"
// because in "devtools" protocol we dont need gridUrl, but it still has to be valid URL
gridUrl = config.gridUrl === LOCAL_GRID_URL ? DEFAULT_GRID_URL : config.gridUrl;
gridUrl = config.gridUrl === LOCAL_GRID_URL ? "http://localhost:4444/wd/hub" : config.gridUrl;
}

const gridUri = new URI(gridUrl);
Expand Down
4 changes: 2 additions & 2 deletions src/config/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
"use strict";

const { DisableHoverMode } = require("../browser/isomorphic");
const { WEBDRIVER_PROTOCOL, SAVE_HISTORY_MODE, NODEJS_TEST_RUN_ENV } = require("../constants/config");
const { WEBDRIVER_PROTOCOL, SAVE_HISTORY_MODE, NODEJS_TEST_RUN_ENV, LOCAL_GRID_URL } = require("../constants/config");
const { TimeTravelMode } = require("./types");

module.exports = {
baseUrl: "http://localhost",
gridUrl: "http://localhost:4444/wd/hub",
gridUrl: LOCAL_GRID_URL,
browserWSEndpoint: null,
desiredCapabilities: null,
automationProtocol: WEBDRIVER_PROTOCOL,
Expand Down
Loading