fix!: remove global helpers (it,describe,...)

src/globals.ts

@@ -0,0 +1,16 @@
+import type {
+    GlobalAfterEachType,
+    GlobalBeforeEachType,
+    GlobalDescribeType,
+    GlobalHermioneType,
+    GlobalItType,
+    GlobalTestplaneType,
+    TestplaneGlobals,
+} from "./types/globals";
+
+export const it: GlobalItType = (globalThis as unknown as TestplaneGlobals).it;
+export const describe: GlobalDescribeType = (globalThis as unknown as TestplaneGlobals).describe;
+export const beforeEach: GlobalBeforeEachType = (globalThis as unknown as TestplaneGlobals).beforeEach;
+export const afterEach: GlobalAfterEachType = (globalThis as unknown as TestplaneGlobals).afterEach;
+export const testplane: GlobalTestplaneType = (globalThis as unknown as TestplaneGlobals).testplane;
+export const hermione: GlobalHermioneType = (globalThis as unknown as TestplaneGlobals).hermione;

src/index.ts

@@ -6,11 +6,11 @@ import "./browser/types";
 // Declares global expect function
 import "expect-webdriverio";
 
-import { GlobalHelper } from "./types";
 export { run as runCli } from "./cli";
 export { Testplane as default } from "./testplane";
 export { Key } from "@testplane/webdriverio";
 export * from "./mock";
+export * from "./globals";
 
 export * as unstable from "./unstable";
 
@@ -46,24 +46,3 @@ export type { SaveStateData } from "./browser/commands/saveState";
 
 import type { TestDefinition, SuiteDefinition, TestHookDefinition } from "./test-reader/test-object/types";
 export type { TestDefinition, SuiteDefinition, TestHookDefinition };
-
-declare global {
-    /* eslint-disable no-var */
-    // Here, we ignore clashes of types between Mocha and Testplane, because in production we don't include @types/mocha,
-    // but we need mocha types in development, so this is an issue only during development.
-    ///@ts-expect-error: see explanation above
-    var it: TestDefinition;
-    // @ts-expect-error: see explanation above
-    var describe: SuiteDefinition;
-    // @ts-expect-error: see explanation above
-    var beforeEach: TestHookDefinition;
-    // @ts-expect-error: see explanation above
-    var afterEach: TestHookDefinition;
-
-    var testplane: GlobalHelper;
-    /**
-     * @deprecated Use `testplane` instead
-     */
-    var hermione: GlobalHelper;
-    /* eslint-enable no-var */
-}

src/test-reader/test-parser.ts

@@ -21,6 +21,7 @@ import { isRunInBrowserEnv } from "../utils/config";
 import { BrowserConfig } from "../config/browser-config";
 import type { ReadTestsOpts } from "../testplane";
 import { TagFilter } from "../utils/cli";
+import { TestplaneGlobals } from "../types/globals";
 
 export type TestParserParseOpts = {
     browserId: string;
@@ -63,8 +64,8 @@ export class TestParser extends EventEmitter {
             also: AlsoController.create(eventBus),
         };
 
-        global.testplane = toolGlobals;
-        global.hermione = toolGlobals;
+        (globalThis as unknown as TestplaneGlobals).testplane = toolGlobals;
+        (globalThis as unknown as TestplaneGlobals).hermione = toolGlobals;
 
         this.#buildInstructions
             .push(Instructions.extendWithBrowserId)

src/types/globals.ts

@@ -0,0 +1,18 @@
+import type { GlobalHelper } from ".";
+import type { SuiteDefinition, TestDefinition, TestHookDefinition } from "../test-reader/test-object/types";
+
+export type GlobalItType = TestDefinition;
+export type GlobalDescribeType = SuiteDefinition;
+export type GlobalBeforeEachType = TestHookDefinition;
+export type GlobalAfterEachType = TestHookDefinition;
+export type GlobalTestplaneType = GlobalHelper;
+export type GlobalHermioneType = GlobalHelper;
+
+export type TestplaneGlobals = {
+    it: GlobalItType;
+    describe: GlobalDescribeType;
+    beforeEach: GlobalBeforeEachType;
+    afterEach: GlobalAfterEachType;
+    testplane: GlobalTestplaneType;
+    hermione: GlobalHermioneType;
+};