Skip to content

fix: make BrowserConfig typing deterministic #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ekazakov14 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make BrowserConfig typing deterministic #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/config/browser-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@ import * as _ from "lodash";
import type { Test } from "../types";
import type { CommonConfig } from "./types";

export interface BrowserConfig extends CommonConfig {
id: string;
}

export class BrowserConfig {
constructor(browserOptions: CommonConfig) {
constructor(browserOptions: CommonConfig & { id: string }) {
_.extend(this, browserOptions);
}

Expand Down
6 changes: 0 additions & 6 deletions src/config/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,9 +480,3 @@ export interface RuntimeConfig {
declare module "." {
export interface Config extends ConfigParsed {}
}

declare module "./browser-config" {
export interface BrowserConfig extends CommonConfig {
id: string;
}
}