Skip to content

Conversation

@allenhutchison
Copy link
Contributor

This PR adds authentication status updates to the MCP server logs, allowing the user to see when they need to check their browser for authentication.

Fixes #135

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the user authentication experience by providing clear, real-time status updates directly within the MCP server logs. By integrating the AuthManager with the server's logging capabilities, users will now receive explicit prompts to check their browser during the authentication process and more informative error messages if the login times out, ultimately streamlining troubleshooting and improving usability.

Highlights

  • Authentication Status Updates: Implemented a new mechanism within the AuthManager to broadcast authentication status messages, providing real-time feedback during the login process.
  • MCP Server Logging Integration: Integrated the authentication status updates with the McpServer's logging system, ensuring these messages are visible in the server logs as info level entries.
  • Improved User Guidance: Enhanced the messages displayed during the web authentication flow, including a clear prompt to check the browser and a more descriptive error message for authentication timeouts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a useful feature for notifying users about the authentication status through MCP logging. The implementation is solid, using a callback mechanism in AuthManager to decouple it from the MCP server. My review includes one suggestion to remove some commented-out code to improve the overall code quality and maintainability.

Copy link

@abhipatel12 abhipatel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

// Trigger auth flow immediately on startup
await authManager.getAuthenticatedClient();

// 2. Create the server instance

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably delete "2." here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uninstall to undo hang on startup gemini extensions uninstall google-workspace

2 participants