Clean up spec helpers, especially the Loggable module
#687
+14
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These extra empty lines are pretty arbitrarily inserted and makes the readability worse so be consistent about the code style.
This commented out code seems like it was left here by accident and that it does not provide any value for future readers.
The code for colorizing text was unnecessarily complex for the few callers it had. It can be simplified even further, e.g. by dropping support for having multiple attributes, but that is left for fututre cleanups.
By making sure we always call the logging test helpers with a single string we can simplify the code for them. The only callers with a list were Loggable#run and Loggable#log_and_run.
Flattening the input is not necessarily since no caller calls us with anything which needs to be flattened.
Collaborator
|
Looks all good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to clean up the test helpers and especially simplify the code and improve the readability of the
Loggablemodule. There were a lot of dead code paths in that module and unnecessarily complicated logic. It can be further simplified but I think this is good enough for now.Changes:
traceandmessage)runandlog_and_runtest helpers