[demo-ready] support QPDK: Merging features from palace-server#28
[demo-ready] support QPDK: Merging features from palace-server#28vvahidd merged 20 commits intogdsfactory:mainfrom
Conversation
…t for cpw. Meshing resonator hangs
Co-authored-by: Niko Savola <nikomsavola@gmail.com>
Thanks, Nico! I'm not sure this is fully working yet. The example does run and generates a mesh, but I think we might still need to merge from main to get the ports right and we'll also probably need the planar conductors too, which aren't tested against the rest of the stack so I'm aftraid there could be some bugs there. Then we should also re-implement the josephson inductor as a lumped element and re-run the full tests (eigenvalue and S-parameters)... |
There was a problem hiding this comment.
How can these be run right now?
With the cloud runner I get
---------------------------------------------------------------------------
NotImplementedError Traceback (most recent call last)
Cell In[6], line 1
----> 1 results = sim.run()
2 # sim.write_config()
3 # results = sim.run_local()
5 if results.ok:
File ~/dev/gsim/src/gsim/palace/eigenmode.py:578, in EigenmodeSim.run(self, output_dir, verbose)
560 def run(
561 self,
562 output_dir: str | Path | None = None,
563 *,
564 verbose: bool = True,
565 ) -> dict[str, Path]:
566 """Run eigenmode simulation on GDSFactory+ cloud.
567
568 Args:
(...) 576 NotImplementedError: Eigenmode is not yet fully implemented
577 """
--> 578 raise NotImplementedError(
579 "Eigenmode simulation is not yet fully implemented on cloud. "
580 "Use DrivenSim for S-parameter extraction."
581 )
NotImplementedError: Eigenmode simulation is not yet fully implemented on cloud. Use DrivenSim for S-parameter extraction.and trying with
sim.write_config()
results = sim.run_local()I get
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[7], line 2
1 # results = sim.run()
----> 2 sim.write_config()
3 results = sim.run_local()
5 if results.ok:
File ~/dev/gsim/.venv/lib/python3.12/site-packages/pydantic/main.py:1026, in BaseModel.__getattr__(self, item)
1023 return super().__getattribute__(item) # Raises AttributeError if appropriate
1024 else:
1025 # this is the current error
-> 1026 raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')
AttributeError: 'EigenmodeSim' object has no attribute 'write_config'Seems the run_local is also implemented only for driven sims but the code could likely be just moved to https://github.com/gdsfactory/gsim/blob/main/src/gsim/palace/base.py

This became quite a large PR that implements several changes we should probably merge one by one.
Computing time: 4.25 minute run in a 16-core Ryzen 9, 64 GB of RAM: