Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates public cell line and omics data from the DepMap Portal (24Q4 release) into the gDRtestData package, adding dataset documentation, a data preparation script, a detailed vignette, and corresponding Rd files. Feedback on these changes focuses on fixing a syntax error and an incorrect reference in the dataset documentation, replacing a hardcoded absolute path in the preparation script with a relative path to ensure portability, and improving the robustness of the script's column-handling logic when separating ID and numeric columns.
bczech
approved these changes
Jun 1, 2026
Contributor
|
GJ! |
gladkia
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Related JIRA issue:
GDR-3410
Why was it changed?
To allow using DepMap data in examples accross gDRplatform
Checklist for sustainable code base
Logistic checklist
Screenshots (optional)