Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
bczech
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Replaced the Docker-based pkgdown workflow with a lightweight r-lib/actions-based approach. Removed dependency on the marcinkam/gdrshiny Docker image, docker/build-push-action, and private access token secrets. The workflow now uses r-lib/actions/setup-r and r-lib/actions/setup-r-dependencies to install R and package dependencies directly on the runner.
Related JIRA issue: GDR-3418
Why was it changed?
The Docker base image marcinkam/gdrshiny:1.0 is no longer accessible on Docker Hub, causing all pkgdown workflow runs to fail. Since all github gDR packages are publicly available in Bioconductor and on GitHub, Docker is unnecessary for pkgdown site generation. The r-lib/actions approach is the standard in the R community — simpler, easier to maintain, and has no external image dependency
EDIT: