Skip to content

Gdr 3418#98

Merged
darsoo merged 7 commits into
mainfrom
GDR-3418
Jun 2, 2026
Merged

Gdr 3418#98
darsoo merged 7 commits into
mainfrom
GDR-3418

Conversation

@darsoo
Copy link
Copy Markdown
Contributor

@darsoo darsoo commented Jun 1, 2026

Description

What changed?

Replaced the Docker-based pkgdown workflow with a lightweight r-lib/actions-based approach. Removed dependency on the marcinkam/gdrshiny Docker image, docker/build-push-action, and private access token secrets. The workflow now uses r-lib/actions/setup-r and r-lib/actions/setup-r-dependencies to install R and package dependencies directly on the runner.

Related JIRA issue: GDR-3418

Why was it changed?

The Docker base image marcinkam/gdrshiny:1.0 is no longer accessible on Docker Hub, causing all pkgdown workflow runs to fail. Since all github gDR packages are publicly available in Bioconductor and on GitHub, Docker is unnecessary for pkgdown site generation. The r-lib/actions approach is the standard in the R community — simpler, easier to maintain, and has no external image dependency

EDIT:

  • Replaced Docker-based CI workflow (main.yml) with r-lib/actions, calling gDRstyle::checkPackage() directly instead of per-repo rplatform/run_tests.sh
  • Split CI into separate jobs: check_membership, external_check, internal_trigger, deploy-dev
  • Removed exit 1 hack — internal_trigger now succeeds after triggering GitLab
  • external_check posts test-result commit status, matching GitLab's behavior for consistent branch protection
  • Renamed workflow display name from main to CI
  • Branch protection should require test-result status check (from any source)

@darsoo darsoo requested a review from a team as a code owner June 1, 2026 16:55
@darsoo darsoo requested review from bczech and j-smola June 1, 2026 16:55
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown
Contributor

@gladkia gladkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@darsoo darsoo merged commit 29cd77d into main Jun 2, 2026
5 checks passed
@darsoo darsoo deleted the GDR-3418 branch June 2, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants