Conversation
Address lint violations from updated gDRstyle rules: - Fix trailing whitespace and blank lines - Replace nrow/ncol with NROW/NCOL - Fix paste_linter (paste0+collapse, toString, strrep, file.path) - Fix seq_linter (seq_along, seq_len) - Refactor cyclocomp_linter violations (extract helper functions) - Fix test linters (yoda, expect_true_false) - Remove undesirable operators (|> pipes)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request performs extensive code cleanup and minor refactoring across the package, primarily focusing on standardizing whitespace and replacing nrow() and ncol() with NROW() and NCOL() for better robustness. It also improves string concatenation in error and warning messages using toString() and paste(..., collapse = ...). A review comment suggests refactoring a long anonymous function within the create_SE function into a dedicated helper to reduce cyclomatic complexity and improve maintainability.
darsoo
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Related JIRA issue: GDR-1014
Why was it changed?
Updated gDRstyle linting rules require compliance across all gDR packages.
Checklist for sustainable code base
Logistic checklist