fix: let /review satisfy ship readiness#338
Open
malikrohail wants to merge 1 commit intogarrytan:mainfrom
Open
fix: let /review satisfy ship readiness#338malikrohail wants to merge 1 commit intogarrytan:mainfrom
malikrohail wants to merge 1 commit intogarrytan:mainfrom
Conversation
Author
|
@garrytan verified on March 22, 2026. I kept this PR intentionally narrow to the
It only makes a normal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/reviewreadiness log entry for the main review result/shipto treatreviewandplan-eng-reviewas valid Eng Review sources/review->/shiphandoff onlyScope
This is the narrow slice of #280:
/review->/shipreadiness handoff/plan-eng-reviewProblem
On current
main,/reviewnever persists a top-level review readiness entry, and/shiponly treatsplan-eng-reviewas satisfying the Eng Review gate. That leaves the Review Readiness Dashboard in a falseNOT CLEAREDstate even after a real/reviewrun.Fix
Step 5.8: Persist Eng Review resultto/review{"skill":"review", ...}entry after a real review completesrevieworplan-eng-review/reviewor/plan-eng-reviewRefs #280.
Verification
bun run gen:skill-docsbun run gen:skill-docs --host codexbun test test/gen-skill-docs.test.ts test/skill-validation.test.tsbun test{"skill":"review"}entry viabin/gstack-review-logbin/gstack-review-readreturns it