docs(codex): rename Step 0 to avoid collision with platform-detect prelude#1394
Open
mvanhorn wants to merge 2 commits intogarrytan:mainfrom
Open
docs(codex): rename Step 0 to avoid collision with platform-detect prelude#1394mvanhorn wants to merge 2 commits intogarrytan:mainfrom
mvanhorn wants to merge 2 commits intogarrytan:mainfrom
Conversation
…elude The codex skill template had its own '## Step 0: Check codex binary' heading (line 42), which after gen-skill-docs collided with the platform-detection prelude '## Step 0: Detect platform and base branch' (injected by scripts/resolvers/utility.ts). The generated codex/SKILL.md ended up with two H2 headings labeled Step 0, which is ambiguous to an agent reading the skill in order. Renamed the local heading to Step 0.4, slotting it between the prelude (Step 0) and the existing Step 0.5 / Step 0.6 sections. No renumbering of downstream steps needed. Closes garrytan#1388 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex/SKILL.mdhad two## Step 0:H2 headings sitting back-to-back: the platform-detect prelude (## Step 0: Detect platform and base branch, injected viascripts/resolvers/utility.ts) and the codex skill's own## Step 0: Check codex binaryfromcodex/SKILL.md.tmpl:42. An agent reading the skill in order hits both with no clear cue which to follow.Why this matters
#1388 reports the collision and proposes three options (
Step 0a/0b, merge, or relabel one asStep 0.5). TheStep 0.5option is taken, so this PR uses the next free fractional slot.Changes
Renamed
codex/SKILL.md.tmpl:42from## Step 0: Check codex binaryto## Step 0.4: Check codex binary. The new label slots between the prelude (Step 0) and the existingStep 0.5: Auth probe + version check/Step 0.6: Resolve portable rootssections, so reading order stays correct and no downstream renumbering is needed.After the rename,
codex/SKILL.mdhas exactly one## Step 0:heading: the platform-detect prelude at line 746.Testing
bun test test/skill-validation.test.ts-> 327 passbun test test/gen-skill-docs.test.ts-> 378 pass, 1 unrelated pre-existing fail (package.json version matches VERSION filepackage.jsonis at 1.29.0.0 vsVERSION1.30.0.0; not touched by this PR)grep -n '^## Step 0' codex/SKILL.mdreturns only the preludeCloses #1388
AI was used for assistance.
Need help on this PR? Tag
@codesmithwith what you need.