Skip to content

Conversation

@GuezelS
Copy link

@GuezelS GuezelS commented Dec 4, 2025

export testresults as inlined ocm-resource

commits.

Add unit-test job and attach test results to component descriptor

Add verify job and attach test-results + gosec-report to component descriptor

How to categorize this PR?

/area compliance
/kind enhancement
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

export testresults as inlined ocm-resource

export testresults as inlined ocm-resource

 commits.

Add unit-test job and attach test results to component descriptor

Add verify job and attach test-results + gosec-report to component descriptor
@GuezelS GuezelS requested review from a team as code owners December 4, 2025 13:59
@gardener-robot gardener-robot added area/compliance Compliance related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure needs/review Needs review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2025
@hebelsan
Copy link
Contributor

hebelsan commented Dec 4, 2025

Hi @GuezelS,
What's the benefit from using this custom workflow over gardener/cc-utils/.github/workflows/sastlint-ocm.yaml?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ GuezelS
❌ I764805


I764805 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@GuezelS
Copy link
Author

GuezelS commented Dec 15, 2025

Hi @GuezelS, What's the benefit from using this custom workflow over gardener/cc-utils/.github/workflows/sastlint-ocm.yaml?

Because we require multiple OCM resource exports (gosec-report and test-results) from a single verification job. The sastlint is not attaching the test-results to the component descriptor.

@hebelsan
Copy link
Contributor

Because we require multiple OCM resource exports (gosec-report and test-results) from a single verification job. The sastlint is not attaching the test-results to the component descriptor.

Wouldn't it make sense to extend the worklfow gardener/cc-utils/.github/workflows/sastlint-ocm.yaml@master in this case instead of adding this large job in every of our build worklfows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compliance Compliance related kind/enhancement Enhancement, improvement, extension needs/review Needs review platform/openstack OpenStack platform/infrastructure size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants