Skip to content

Refactoring (TODO) #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kostov6 wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Refactoring (TODO) #433

Kostov6 wants to merge 22 commits into from

Conversation

@Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Sep 1, 2025

What this PR does / why we need it:

TODO

Which issue(s) this PR fixes:

TODO

Special notes for your reviewer:

Release note:

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Sep 1, 2025
@gardener-robot
Copy link
Contributor

gardener-robot commented Sep 1, 2025

@Kostov6 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/review Needs review label Sep 1, 2025
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2025
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Sep 1, 2025
@ghost ghost added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2025
Kostov6 added 21 commits September 1, 2025 11:01
@Kostov6
[tested] experiment with channel based approach
45fa026
@Kostov6
Print logs from diff.sh
4d8cac5
@Kostov6
pkg: migrate markdown plugin
81ca808
@Kostov6
pkg: collect external links
e71cd10
@Kostov6
[tested] link validation after plugin processing
3243a5d
@Kostov6
[tested] drop githubinfo
354373a
@Kostov6
[tested] drop taskqueue
d72ac15
@Kostov6
pkg/nodeplugins/markdown: restructure nodeplugins/markdown package
4b8f314
@Kostov6
[tested] Remove unused fields
b98768c
@Kostov6
[tested] test plugin merging
809d23d
@Kostov6
Add todo
a328e22
@Kostov6
pkg: merge manifest plugin into unified plugin interface
4bb1601
@Kostov6
[tested] merge node plugin into unified plugin interface
231e6d1
@Kostov6
[tested] move manifest package into core
c43c024
@Kostov6
[tested] move registry package into core
71d2cda
@Kostov6
[tested] Remove os dependency from fswriter.go and it's callers
8de221f
@Kostov6
[tested] Remove writers package and use osshim
689a9e1
@Kostov6
[tested] all os changes go through osshim
dff1836
@Kostov6
[tested] add core dependency whitelist checker
b7a061d
@Kostov6
[tested] move plugin interface to core
8e45481
@Kostov6
[tested] remove multiSource
33ea23c
@Kostov6 Kostov6 force-pushed the enh/channel-processing branch from 8b53eac to 33ea23c Compare September 1, 2025 08:02
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2025
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2025
@ghost ghost added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2025
@gardener-ci-robot
Copy link

gardener-ci-robot commented Dec 19, 2025

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-robot
Copy link
Contributor

gardener-robot commented Dec 19, 2025

@gardener-ci-robot Command /add is not available to you but only to a Maintainer, Member, Author.

@gardener-ci-robot
Copy link

gardener-ci-robot commented Jan 3, 2026

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2026
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026
@gardener-prow
Copy link

gardener-prow bot commented Jan 13, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kostov6 @gardener-robot @gardener-ci-robot @gardener-robot-ci-1