Skip to content

Make testinstall work with gap --bare#6354

Open
fingolfin wants to merge 4 commits into
masterfrom
mh/test-bare
Open

Make testinstall work with gap --bare#6354
fingolfin wants to merge 4 commits into
masterfrom
mh/test-bare

Conversation

@fingolfin
Copy link
Copy Markdown
Member

@fingolfin fingolfin commented Apr 29, 2026

Resolves #6346

@fingolfin fingolfin added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.74%. Comparing base (61a3638) to head (487d9d7).

Files with missing lines Patch % Lines
lib/test.gi 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6354   +/-   ##
=======================================
  Coverage   78.73%   78.74%           
=======================================
  Files         685      685           
  Lines      293358   293357    -1     
  Branches     8658     8658           
=======================================
+ Hits       230987   230993    +6     
+ Misses      60552    60544    -8     
- Partials     1819     1820    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fingolfin fingolfin force-pushed the mh/test-bare branch 2 times, most recently from a3ea9e6 to 2a6237a Compare May 11, 2026 18:56
@fingolfin fingolfin force-pushed the mh/test-bare branch 3 times, most recently from 35260cd to 1dc65c5 Compare May 17, 2026 22:24
@fingolfin fingolfin added the topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ... label May 17, 2026
@fingolfin fingolfin marked this pull request as ready for review May 17, 2026 22:27
@fingolfin fingolfin requested a review from ThomasBreuer May 17, 2026 22:28
@ThomasBreuer
Copy link
Copy Markdown
Contributor

ThomasBreuer commented May 18, 2026

The failure is due to the fact that Test sets the global function DefaultReportDiffColors only if GAPInfo.PackagesLoaded.gapdoc is bound, which is not the case in the "bare" situation.

As far as I see, this is just about a few text constants. We could set them as in the current GAPDoc's TextAttr if GAPDoc is not available.

@fingolfin
Copy link
Copy Markdown
Member Author

I've added a commit to deal with the DefaultReportDiffColors issue. Let's see if it works.

@fingolfin
Copy link
Copy Markdown
Member Author

Only failure now is in tst/testinstall/package.tst which loads mockpkg which in turn "needs" GAPDoc, which then gets loaded and prints a banner.

I won't get that done for GAP 4.16.0. But I've restricted the other remaining changes from this PR into PR #6406

Copy link
Copy Markdown
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only failure now is in tst/testinstall/package.tst which loads mockpkg which in turn "needs" GAPDoc, which then gets loaded and prints a banner.

I see: Some tests of package extensions are based on the assumption that some GAPDoc version is already loaded. Simply removing GAPDoc from the list of needed packages of mockpkg is not a solution.

Besides this problem, everything looks well. Thanks for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: ci Anything related to GitHub Actions, Codecov, AppVeyor, Coveralls, Travis, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: add a test run with gap --bare

2 participants