Make testinstall work with gap --bare#6354
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
=======================================
Coverage 78.73% 78.74%
=======================================
Files 685 685
Lines 293358 293357 -1
Branches 8658 8658
=======================================
+ Hits 230987 230993 +6
+ Misses 60552 60544 -8
- Partials 1819 1820 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3ea9e6 to
2a6237a
Compare
35260cd to
1dc65c5
Compare
|
The failure is due to the fact that As far as I see, this is just about a few text constants. We could set them as in the current GAPDoc's |
|
I've added a commit to deal with the |
|
Only failure now is in I won't get that done for GAP 4.16.0. But I've restricted the other remaining changes from this PR into PR #6406 |
ThomasBreuer
left a comment
There was a problem hiding this comment.
Only failure now is in
tst/testinstall/package.tstwhich loadsmockpkgwhich in turn "needs"GAPDoc, which then gets loaded and prints a banner.
I see: Some tests of package extensions are based on the assumption that some GAPDoc version is already loaded. Simply removing GAPDoc from the list of needed packages of mockpkg is not a solution.
Besides this problem, everything looks well. Thanks for this work.
Resolves #6346