Admit the syntax SymplecticGroup( IsPlistMatrixRep, 4, GF(4) )#6299
Open
ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
Open
Admit the syntax SymplecticGroup( IsPlistMatrixRep, 4, GF(4) )#6299ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
Conversation
Up to now, we had to say `SymplecticGroup( IsMatrixGroup, 4, GF(4) : ConstructingFilter:= IsPlistMatrixRep )`. For the new syntax, introduce the global list `ConstructingFiltersForMatrixGroupElements` and add the current MatrixObj filters to it. That is, we derive from the fact that `IsPlistMatrixRep` is contained in `ConstructingFiltersForMatrixGroupElements` that `SymplecticGroup( IsPlistMatrixRep, 4, GF(4) )` asks for a matrix group. If this approach is o.k. then I can document it, and change the code for more group constructions to use it.
ThomasBreuer
added
kind: new feature
topic: library
release notes: not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now, we had to say
SymplecticGroup( IsMatrixGroup, 4, GF(4) : ConstructingFilter:= IsPlistMatrixRep ).For the new syntax, introduce the global list
ConstructingFiltersForMatrixGroupElementsand add the current MatrixObj filters to it.
That is, we derive from the fact that
IsPlistMatrixRepis contained inConstructingFiltersForMatrixGroupElementsthatSymplecticGroup( IsPlistMatrixRep, 4, GF(4) )asks for a matrix group.If this approach is o.k. then I can document it, and change the code for more group constructions to use it.
(A separate commit fixes two
NewMatrixmethods, the situation that the matrix is given by a flat list was not handled before.)