fix a problem with a new feature for matrix groups#6232
Open
ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
Open
fix a problem with a new feature for matrix groups#6232ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
ThomasBreuer wants to merge 2 commits intogap-system:masterfrom
Conversation
- add a description of the cache `FULLGLNICOCACHE` in the code; it is used only by `NicomorphismFFMatGroupOnFullSpace` - change the keys of `FULLGLNICOCACHE`: take the field of the matrix entries into account (not only its size), take the `ConstructingFilter` of the matrices into account - in `NicomorphismFFMatGroupOnFullSpace`, deal with special cases of matrices in `IsBlockMatrixRep` (which have no `ConstructingFilter`) and in `Is8BitMatrixRep` in the situation that the group itself lives over `GF(2)` - in order to admit the action of `IsMatrixObj` matrices on vectors supported by GAP's `Enumerator`s of vector spaces, add a `\^` method that `Unpack`s the matrix object (Eventually we want to avoid this overhead, but then we need `Enumerator`s consisting of vector objects corresponding to the matrix objects.) - add `Matrix` calls in the function that computes preimages under an action homomorphism with `Source` a matrix group, in order to support matrix group elements of prescribed kinds of `IsMatrixObj`. - add tests for the new supported situations (most of the changes were actually forced by already available tests)
ThomasBreuer
added
kind: bug
Contributor
Author
|
repeated failures due to problems like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(resolves #6222)
FULLGLNICOCACHEin the code; it is used only byNicomorphismFFMatGroupOnFullSpaceFULLGLNICOCACHE: take the field of the matrix entries into account (not only its size), take theConstructingFilterof the matrices into accountNicomorphismFFMatGroupOnFullSpace, deal with special cases of matrices inIsBlockMatrixRep(which have noConstructingFilter) and inIs8BitMatrixRepin the situation that the group itself lives overGF(2)IsMatrixObjmatrices on vectors supported by GAP'sEnumerators of vector spaces, add a\^method thatUnpacks the matrix object (Eventually we want to avoid this overhead, but then we needEnumerators consisting of vector objects corresponding to the matrix objects.)Matrixcalls in the function that computes preimages under an action homomorphism withSourcea matrix group, in order to support matrix group elements of prescribed kinds ofIsMatrixObj.\inmethods forGLandSLgroups where the first argument is inIsMatrixObj(such that no nice monomorphism is used in this situation)