Make RestrictedMapping of a group homomorphism use the same Range as the original morphism#6230
Open
stertooy wants to merge 1 commit intogap-system:masterfrom
Open
Make RestrictedMapping of a group homomorphism use the same Range as the original morphism#6230stertooy wants to merge 1 commit intogap-system:masterfrom
RestrictedMapping of a group homomorphism use the same Range as the original morphism#6230stertooy wants to merge 1 commit intogap-system:masterfrom
Conversation
ThomasBreuer
added
the
release notes: use title
ThomasBreuer
approved these changes
Feb 12, 2026
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
The proposed changes are correct.
In another pull request, we will eventually
- extend the documentation of
RestrictedMappingin order to state what the return value is, - make sure that all methods of
RestrictedMappingfit to this description, - document the
surjectiveoption that is used already in at least one of these methods.
ThomasBreuer
changed the title
RestrictedMapping of a group homomorphism use the same Range as the original morphism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6225
Text for release notes
see title
Further details
Shouldn't have much impact, unless some other code actually relied on
RestrictedMappingreturning a surjective map.