WIP: gap root path unification#5941
Draft
fingolfin wants to merge 2 commits intogap-system:masterfrom
Draft
Conversation
fingolfin
commented
Feb 18, 2025
fingolfin
commented
Feb 18, 2025
fingolfin
commented
Feb 18, 2025
| fi; | ||
| od; | ||
| # Append the new root paths. | ||
| GAPInfo.RootPaths:= Immutable( Concatenation( GAPInfo.RootPaths, |
Member
Author
There was a problem hiding this comment.
I've replaced this now with a loop that uses Add to add each path separately. Various reasons
- the "skip paths already in the list" is more powerful if we do it after ensuring the trailing slash is there
- for HPC-GAP compatibility we may have to switch
GAPInfo.RootPathsfrom a plist to an atomic list, whereAddis supported but notAppend
Anyway this is of course also a natural place to turn relative paths in absolute ones, call realpath, etc. -- but that goes beyond the scope of this PR
fingolfin
commented
Feb 19, 2025
| ** returned as a string object. If no file is found then NULL is returned. | ||
| */ | ||
| Char * SyFindGapRootFile(const Char * filename, Char * buf, size_t size) | ||
| Obj SyFindGapRootFile(const Char * filename) |
Member
Author
There was a problem hiding this comment.
Unfortunately changing SyFindGapRootFile to return a string object currently clashes with workspace restoring as it is called during that when restoring loaded compiled modules (including kernel extensions).
This was referenced Jun 19, 2025
063917f to
b72d773
Compare
b72d773 to
023b4e0
Compare
Member
|
Looking good so far 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not yet quite done, but the goal is to ensure that the GAP kernel and library use the same (identical, egal) plist of root paths.
This has multiple benefits:
TODO:
~into$HOMENote that most likely right workspaces are simply broken, but if so I know why and this will be addressed by the above.
Resolves #4675