Allow factorizing permutations into words in somewhat larger examples#5854
Open
fingolfin wants to merge 1 commit intogap-system:masterfrom
Open
Allow factorizing permutations into words in somewhat larger examples#5854fingolfin wants to merge 1 commit intogap-system:masterfrom
fingolfin wants to merge 1 commit intogap-system:masterfrom
Conversation
The old bound were somewhat conservative on current systems. Esp. the total limit of 25000 was very low.
hulpke
approved these changes
Dec 2, 2024
Contributor
hulpke
left a comment
There was a problem hiding this comment.
Yes, this is a relic of olden times. Could even increase by a factor of 5 by now.
(There are other places where code sets memory usage limits. Do we want to have a general framework how much memory we consider appropriate for a routine to gobble?)
Member
Author
|
Yeah perhaps we should think about a more systematic way to track such "magic numbers" and limits so that we can scale them better over time... In the meantime, I am surprised that this change causes a regression with a relatively small example in the manual, in Apparently with this change, instead of a word of length 13 it finds one of length 57? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak limits for Minkwitz algorithm. The old bound were somewhat conservative on current systems. Esp. the total limit of 25000 was very low.