buildsys: always link gap against libgap#5780
Draft
fingolfin wants to merge 4 commits intogap-system:masterfrom
Draft
buildsys: always link gap against libgap#5780fingolfin wants to merge 4 commits intogap-system:masterfrom
fingolfin wants to merge 4 commits intogap-system:masterfrom
Conversation
fingolfin
added
topic: build system
release notes: not needed
ChrisJefferson
approved these changes
Aug 28, 2024
fingolfin
force-pushed
the
mh/always-use-libgap
branch
from
7ccddc9 to
98f8479
Compare
... even the copy we don't install system wide. On macOS this allows us an annoying issue with the linker flags used by e.g. gac for building kernel extensions: by always linking them against libgap we don't need to use a flat namespace, nor rely on a bundle loader (which breaks if you try to load the kernel extension in another binary using libgap).
fingolfin
force-pushed
the
mh/always-use-libgap
branch
from
98f8479 to
f90cf4f
Compare
fingolfin
commented
Jun 23, 2025
| # Linking rule and dependencies for libgap | ||
| $(LIBGAP_FULL): $(OBJS) cnf/GAP-LDFLAGS cnf/GAP-LIBS cnf/GAP-OBJS | ||
| $(QUIET_LINK)$(LINK) -o $@ $(LINK_SHLIB_FLAGS) $(GAP_LDFLAGS) $(OBJS) $(GAP_LIBS) | ||
| $(QUIET_LINK)$(LINK) -o $@ $(LINK_SHLIB_FLAGS) $(GAP_LDFLAGS) -Wl,-rpath,$(abs_builddir) $(OBJS) $(GAP_LIBS) |
Member
Author
There was a problem hiding this comment.
needs to be relinked for install. macOS build works around this using install_name_tool, but instead we can just relink, just like we do for the gap executable itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... even the copy we don't install system wide.
On macOS this allows us an annoying issue with the linker flags used by e.g.
gac for building kernel extensions: by always linking them against libgap we
don't need to use a flat namespace, nor rely on a bundle loader (which breaks
if you try to load the kernel extension in another binary using libgap).
However, this is not yet working on Linux at all, as there it won't find the not-yet-installed libgap:
In principle this can be dealt with but I don't have time to do that right now, but I also didn't want to let this fragment get lost, so this PR will remind me to finish this one day (if someone would like to help out, that'd be welcome, too).
Alternatively one could restrict this change to macOS.