Adjust ConformalSymplecticGroup to matrix object changes#86
Merged
Conversation
Now we make sure that all matrix multiplications happen w.r.t. the same representation. Note that issue #6221 of GAP describes possible problems, and pull request #6240 of GAP provides a fix, which causes in our situation that some multiplications are no longer allowed. Thus we turn all matrices stored in forms objects into matrices that fit to the representation of the given group generators. Also, we use `Matrix` only in the variant that prescribes `ConstructingFilter` and `BaseDomain`, the variant that prescribes just an example matrix object is dangerous in the situation that we are dealing with `IsGF2MAtrixRep` or `Is8BitMatrixRep` matrices. (Eventually it will be desirable to admit matrix objects of the right representation also in as data of the forms objects, but this is nothing we can force now.)
- test more filters (we have learned that `IsGF2MatrixRep` and `Is8BitMatrixRep` need explicit checks) - add some tests that were commented out but now work, due to improvements in the GAP library - test equality of groups with `\=` not with an artificial `is_equal` function, which is possible (and in fact faster) due to improvements in the GAP library
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 80.97% 81.49% +0.51%
==========================================
Files 6 8 +2
Lines 3690 3831 +141
==========================================
+ Hits 2988 3122 +134
- Misses 702 709 +7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we make sure that all matrix multiplications happen w. r. t. the same representation.
Note that issue #6221 of GAP describes possible problems, and pull request #6240 of GAP provides a fix, which causes in our situation that some multiplications are no longer allowed.
Thus we turn all matrices stored in forms objects into matrices that fit to the representation of the given group generators.
Also, we use
Matrixonly in the variant that prescribesConstructingFilterandBaseDomain, the variant that prescribesjust an example matrix object is dangerous in the situation that we are dealing with
IsGF2MAtrixReporIs8BitMatrixRepmatrices.
(Eventually it will be desirable to admit matrix objects of the right representation also in as data of the forms objects, but this is nothing we can force now.)
And revisit the ConformalSymplecticGroup tests:
IsGF2MatrixRepandIs8BitMatrixRepneed explicit checks)\=not with an artificialis_equalfunction, which is possible (and in fact faster) due to improvements in the GAP library