Fix scalar normalization in ClassicalForms_GeneratorsWithBetterScalarsSesquilinear#84
Merged
fingolfin merged 2 commits intoMay 17, 2026
Conversation
In ClassicalForms_GeneratorsWithBetterScalarsSesquilinear, - use exponent q+1 instead of 2 - remove root-based normalization
Member
|
@jdebeule @johnbamberg ping -- any thoughts on this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 80.97% 81.20% +0.23%
==========================================
Files 6 6
Lines 3690 3688 -2
==========================================
+ Hits 2988 2995 +7
+ Misses 702 693 -9
🚀 New features to boost your workflow:
|
fingolfin
reviewed
May 6, 2026
Member
|
@jdebeule @johnbamberg I haven't heard from you, but we do need this fix. So I'll go ahead and merge this, and make a release. |
fingolfin
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issues described in #83:
q+1instead of2, which corrects the unitary case,This (hopefully) improves detection of forms preserved up to scalar without changing the overall algorithm.