Don't call MaxSubIntersections if IdGroup is not available#19
Open
stertooy wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 13 13
Lines 1745 1746 +1
=======================================
+ Hits 1547 1548 +1
Misses 198 198
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: gap-system/gap#2434
The function
MaxSubIntersectionscurrently assumes thatIdGroupis available whenever it is called. And the functionPGCharSubgroupscallsMaxSubIntersections( G )ifGhas size at most 512, so everything works fine if theSmallGrppackage is loaded... but this causes an error when it's not.This PR adds a check to see if
IdGroupreally is available, in addition to the size constraint.