Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 13 13
Lines 1745 1746 +1
=======================================
+ Hits 1547 1548 +1
Misses 198 198
🚀 New features to boost your workflow:
|
hulpke
approved these changes
Aug 28, 2025
hulpke
left a comment
There was a problem hiding this comment.
Programming logic is certainly fine. It would be nice to find out why phom cannot compute pre-images, but the inverse can compute images.
I know that I suggested the change, but it is admittedly in the "hack to make it work" category, and I did not fuillyu understand the underlying problem.
Member
Author
|
Thanks @hulpke that's helpful. I was also really puzzled by this but I didn't want to forget about it |
This resolves gap-packages/anupq#67 where the following code would get stuck in the last line: LoadPackage("anupq");; G:=SmallGroup(512,383371);; H:=SmallGroup(512,383419);; PqStandardPresentation(G); PqStandardPresentation(H);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves gap-packages/anupq#67 where the following code would get stuck in the last line:
See gap-packages/anupq#67 (comment) where @beick described this fix which was suggested by @hulpke