Wrap CXXFLAGS test with double quotes in configure.ac#160
Merged
gansm merged 1 commit intogansm:mainfrom Feb 17, 2026
Merged
Conversation
Without the quotes when configuring with CXXFLAGS;
./configure CXXFLAGS='-g -O0' CPPFLAGS='-I$(top_srcdir)'
The test is interpreted as:
test -z -g -O0
resulting in an error amongst the output like:
. . .
checking whether gcc understands -c and -o together... (cached) yes
./configure: line 6360: test: -g: binary operator expected
checking for g++... g++
checking whether the compiler supports GNU C++... yes
. . .
Owner
|
Hi Frank, thanks for your pull request. I added this line on October 15, 2021, which was four years, four months, and two days ago. So your fix is just two days too early 😄. Your patch now clearly prevents the word-splitting problem. |
Contributor
Author
|
Hi Markus, it's funny how long things can go unnoticed. I must admit it was a while before I noticed the warning message whizzing up the screen, so I'm not surprised! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the quotes when configuring with CXXFLAGS;
The test is interpreted as:
resulting in an error amongst the output like: