Fix memory issues crashing the pipelines#1
Conversation
- Prevent standard C double frees and cross-boundary errors by copying Rust-allocated translated strings into standard C memory with `strdup` before processing and freeing the Rust string via `free_translated_sql`. - Handle C memory safely with standard `free` after duplication. - Replaced `strdup` with `sqlite3_mprintf` for `errmsg` output formatting in `sqlite3_exec` because SQLite eventually uses `sqlite3_free` internally, preventing a segfault from mismatched allocators. Co-authored-by: ganey <1401832+ganey@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed memory allocation and freeing bugs in
sqlite_hook.cthat caused pipeline tests and subsequent executions to fail with invalid pointer errors. Specifically, handled the correct string copies across C and Rust boundaries and replaced standard string allocation withsqlite3_mprintfwhere necessary to avoid double-free/incorrect allocators on error strings in sqlite implementations.PR created automatically by Jules for task 12729744583254747715 started by @ganey