feat: add pre-filled jira link to pr template #4
Conversation
pull_request_template.md
Outdated
|
|
||
| ## Purpose of Change | ||
|
|
||
| ## Ticket Link |
There was a problem hiding this comment.
most repos have the autolink setting enabled, so a full example jira URL isn’t necessary since they’ll just use something like “BE-1234” which will automatically link to jira
id say putting the header for the link is good, but an example placeholder will probably cause more friction than help, and any friction is just an annoyance that will be circumvented by other means
There was a problem hiding this comment.
LMAO thank you @spencerkordecki - i've been meaning to shoot you a text! with this review, you did 3 things
- prompted me to make this repo private
- assured us that we need to reinstall our 7 year old Jira-GH integration
- got a text from me
There was a problem hiding this comment.
ah, but i remembered we made this decision intentionally. @kendallm announced it as public, too. and here's the GH doc stating the req.
There was a problem hiding this comment.
@jamietsao would you mind doing the uninstall/reinstall we were talking about?
There was a problem hiding this comment.
This was done FYI. Discussion in slack message between the three of us.
|
and also for reference to your PR body, the “rollout” will take place once this is merged. unless the repos override their templates, any new PR created for that repo will use the changes you make here in this directory |
Co-authored-by: jeffatgametime <48690769+jeffatgametime@users.noreply.github.com>
Co-authored-by: jeffatgametime <48690769+jeffatgametime@users.noreply.github.com>
|
@spencerkordecki thanks for the rollout info. I have updated the PR description. Jeff updated with your suggestion. |
3 participants
The following code makes an impact.
Purpose of Change
Keep the PR template slim but make it easy to link to the requirements of a ticket in JIRA for review and context
Change Overview
Add easy to update pre-filled link to Jira tickets to the Gametime PR template
Affected Functionality
Org wide PR template will be updated, albeit slightly
Testing
N/A
Observability
N/A
Rollout
Merging will rollout this template to the entire org