Skip to content

fix: dropping files not converting #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Mar 10, 2026
Merged

fix: dropping files not converting #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b7262
fix: dropping files not converting
Mar 9, 2026
33294d5
version bumped
Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cimo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* Author URI: http://gambit.ph
* License: GPLv2 or later
* Text Domain: cimo-image-optimizer
* Version: 1.2.2
* Version: 1.2.3
*
* @fs_premium_only /freemius.php, /freemius/, /lib/freemius-php-sdk
*/
Expand Down
4 changes: 4 additions & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,10 @@ Yes! The settings page includes a statistics dashboard showing:

== Changelog ==

= 1.2.3 =

* Fixed: Dropping files stopped working in some instances #32

= 1.2.2 =

* Fixed: Uploading an image via Media > Add Media File doesn't show stats #4
Expand Down
2 changes: 1 addition & 1 deletion src/admin/js/media-manager/drop-zone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function addDropZoneListenerToMediaManager( targetDocument ) {
// is triggered. We might break other funcitonality that we don't have
// the conversion to happen.
if ( ! event.target.closest( '.media-frame-uploader' ) && // Allowed to drop in the Media Manager
! event.target.closest( '.supports-drag-drop' ).querySelector( '.media-frame-uploader' ) && // Allowed a fallback to drop in the Media Manager
! event.target.closest( '.supports-drag-drop' )?.querySelector( '.media-frame-uploader' ) && // Allowed a fallback to drop in the Media Manager
! event.target.closest( '.media-upload-form' ) && // Allowed to drop in the admin Media > Add Media File.
! event.target.closest( '.editor-post-featured-image' ) && // Allowed to drop in the featured image drop zone.
! event.target.closest( '.editor-styles-wrapper' ) && // Allowed to drop in the block editor when adding new image blocks
Expand Down