Fix workflow polling hang when a step stays new behind a paused branch#1648
Open
mvdbeek wants to merge 1 commit into
Open
Fix workflow polling hang when a step stays new behind a paused branch#1648mvdbeek wants to merge 1 commit into
mvdbeek wants to merge 1 commit into
Conversation
When an upstream job errors, Galaxy pauses the downstream step and can leave a further step in the new state. On a poll where the invocation is ready with a paused and errored job, invocation_scheduling_terminal returns True, so _poll_main_workflow stops refreshing the invocation and new_steps is frozen non-empty. all_subworkflows_complete() then blocked on it forever, so the poll loop never returned (observed in IWC CI, ran ~5.5h until cancelled). Skip the new_steps check once scheduling is terminal, since it can no longer change. Add a simulation scenario and regression test, with a tick cap in the test polling tracker so a future non-terminating loop fails instead of hanging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an upstream job errors, Galaxy pauses the downstream step and can leave a further step in the new state. On a poll where the invocation is ready with a paused and errored job, invocation_scheduling_terminal returns True, so _poll_main_workflow stops refreshing the invocation and new_steps is frozen non-empty. all_subworkflows_complete() then blocked on it forever, so the poll loop never returned (observed in IWC CI, ran ~5.5h until cancelled).
Skip the new_steps check once scheduling is terminal, since it can no longer change. Add a simulation scenario and regression test, with a tick cap in the test polling tracker so a future non-terminating loop fails instead of hanging.