Merged
Conversation
DCA with asset_out=stableshare gets terminated instead of retried when the stableshare is in circuit breaker lockdown. The lockdown is temporary so DCA should retry until it expires.
Add DepositLimitExceededForWhitelistedAccount to RetryOnErrorForDca so DCA retries when a stableshare is in circuit breaker lockdown instead of permanently terminating the schedule.
|
Crate versions that have been updated:
Runtime version has been increased. |
When stableshare is in circuit breaker lockdown, DCA now retries instead of terminating. Added integration test verifying successful trade after lockdown is lifted.
enthusiastmartin
approved these changes
Feb 24, 2026
|
Quick benchmark at commit 59d9075 has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a DCA schedule has a route where
asset_outis a stableshare (pool_id), the trade goes through stableswap'sadd_assets_liquiditywhich callsCurrency::deposit(pool_id, ...)to mint shares.If the stableshare is in circuit breaker lockdown, the issuance increase fuse returns
DepositLimitExceededForWhitelistedAccount(because the router account is whitelisted and deposits can't be locked for it).This error was not in
RetryOnErrorForDca, so the DCA schedule was permanently terminated instead of retried. Since lockdowns are temporary, the DCA should retry with exponential backoff until the lockdown expires.Fix
Add
pallet_circuit_breaker::Error::<Runtime>::DepositLimitExceededForWhitelistedAccounttoRetryOnErrorForDcainruntime/hydradx/src/assets.rs.