Conversation
|
Crate versions that have not been updated:
Runtime version has not been increased. |
mrq1911
requested changes
Jan 7, 2026
Member
There was a problem hiding this comment.
- please implement original oracle interface https://github.com/aave/aave-v3-core/blob/master/contracts/dependencies/chainlink/AggregatorInterface.sol as well
- secondary agg meant to be used is our chainlink precompile adapter which is not v3 agg compatible
- add test to hydration integration tests crate which uses chainlink precompile as secondary oracle
…ration-node into ys-oracle-clamp-1220
mrq1911
approved these changes
Jan 22, 2026
|
Quick benchmark at commit 7ce3dbc has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Checklist: