Fix build for node 10 #14
Conversation
fix: skip some tests deps: update deps test: log when skip tests ci: gpg import first deps: revert deps update ci: disable old node version deps: update deps from libxmljs#507
|
@gagern can you help me fix build here? |
|
@corvinrok I'm not sure who the primary maintainers of this fork are. Ideally, I'd like to merge multi-threading support into main repo so we don't need this fork anymore. If anyone here has the time, maybe we could use this as an opportunity to merge the two. |
|
I am very interested in using this library against Node 10... hopeful this will continue to be developed.. or has this been branched elsewhere with active development still going on? |
|
Hi what happen with this? is already done this PR? |
|
@gagern seems to ignore this. This is the death of this module, so, new name? New ownership! |
|
Yes, This is very much needed. v10, v11 and beyond ...
…On Sat, Oct 27, 2018, 7:46 AM jonas bosson ***@***.***> wrote:
@gagern <https://github.com/gagern> seems ignore this. This is the death
of this module, new name? New ownership!
@kbiedrzycki <https://github.com/kbiedrzycki> - would you please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFBdi4HwEj4zVe3_BIjNKocCS3E6cg9iks5upHHcgaJpZM4T9UpD>
.
|
|
Hi @rchipka @corvinrok lets merge both repo. I could help with this. |
|
@gagern ? |
I am happy to help, although you will have to point me to how to do so, as I've yet to contribute to any project. I am an experienced developer, but have yet to work on an open source contribution ... point me to next steps, or assign me tasks and I'll be glad to help.. |
|
@kbiedrzycki: There are a couple of libraries by @albanm which depend on this, and in turn I depend on them. I will work with him to find a way to update them for Node.js 10.x that doesn't cause too much work for him, and that leaves the dependency of this library, which we can agree is not going to be updated. Do you think that you will maintain your fork so that it can become the official MT variant, and then we can use it instead of this one? Just looking for a way to solve this :-) |
|
@kevteljeur yeah I am fine maintaining the fork, sure, however, I might need some help with resolving issues on CI. Also, if we would be able fixing these problems, maybe we can merge them back here, to this repo as well? |
|
Well, that's the big issue, isn't it? :-) I can see from what I had to do with libxslt to fix it, and what i will need to do in the future, that updating the C bridge is an ongoing process with each new version of Node.js. @gagern, would you accept pull requests for new releases, if the work is done by others to update the code here for compatibility with new Node.js releases? I'm even negotiating with Zaytoon to bribe you, Martin. I will bribe you with Zaytoon to get you to accept pull requests. |
7 participants
No description provided.