Skip to content

add TypeScript typings #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timse wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add TypeScript typings #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af360db
add TypeScript typings
timse Jul 26, 2016
a21a07b
make export correct
timse Jan 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import {Component} from 'react';
interface IDocumentTitleProps {
Copy link

@JakeSidSmith JakeSidSmith Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the interface DocumentTitleProps. It is not recommended to prefix interfaces with I (although its somewhat still up for debate).

title: string;
}
declare class DocumentTitle extends Component<IDocumentTitleProps, void> {}
Copy link

@JakeSidSmith JakeSidSmith Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

void is not valid in newer React types. You should use {} for back and forward compatibility.

export = DocumentTitle;
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "2.0.2",
"description": "A declarative, nested, stateful document.title for React",
"main": "index.js",
"typings": "index.d.ts",
"scripts": {
"test": "mocha",
"test:watch": "npm run test -- --watch",
Expand Down