Open
Conversation
crascaroth
requested review from
a user,
BrunoMovio,
MateusGesualdo,
amandarangel,
caioteixeiraa,
jvpalves,
leticia-chijo,
paula-aribeiro,
pdarvas,
pedro-severo and
yuzokamoto
MateusGesualdo
approved these changes
Mar 26, 2021
MateusGesualdo
left a comment
MateusGesualdo
left a comment
There was a problem hiding this comment.
Seu projeto ficou acima do esperado, Douglas, parabéns!
Sugestões de melhoria:
- Criar um arquivo
.gitignorena raiz do projeto - Não misturar português inglês ao nomear variáveis e tipos
- Remover trechos de código comentado
- Utilizar um método alternativo para geração de id's (o que fez pode gerar colisões caso algum usuário seja deletado)
- Gerar sempre mensagens de erro específicas (ex: "Please check the fields." -> por quê?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.