Feat: Add AnnotationLabel CRUD operations and name-based resolution for AnnotationQueue Methods#19
Merged
NVJKKartik merged 4 commits intodevfrom Mar 27, 2026
Merged
Conversation
|
Your trial period has expired. To continue using this feature, please upgrade to a paid plan here or book a time to chat here. |
NVJKKartik
reviewed
Mar 21, 2026
NVJKKartik
requested changes
Mar 21, 2026
NVJKKartik
reviewed
Mar 21, 2026
…nnotationQueue methods for label handling
NVJKKartik
reviewed
Mar 25, 2026
Contributor
NVJKKartik
left a comment
There was a problem hiding this comment.
- assign_items missing item_ids validation — item_ids was changed from a required positional parameter to Optional[List[str]] = None, but no validation guard was added. The sibling method remove_items (line
- has if not item_ids: raise ValueError(...), and the TypeScript assignItems also validates. A caller can now call assign_items(queue_id="q1") and the SDK will silently POST {"item_ids": null} to the API.
futureagi-sdk/python/fi/queues/client.py
Lines 669 to 686 in 4358d15
Compare with remove_items which correctly validates:
futureagi-sdk/python/fi/queues/client.py
Lines 649 to 667 in 4358d15
…t ests for AnnotationQueue
Contributor
Code reviewFound 1 issue:
futureagi-sdk/python/fi/queues/client.py Lines 845 to 895 in c1056e8 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
NVJKKartik
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
create_label,list_labels,get_label,delete_label) toAnnotationQueueclientqueue_idnow also acceptsqueue_name, and every method that acceptslabel_idnow also acceptslabel_nameAnnotationLabelre-export fromfi.queuesmodel-hub/annotations-labels/andmodel-hub/annotations-labels/{label_id}/Changes
fi/queues/client.py_get_queue_id_from_name()and_get_label_id_from_name()resolvers (case-insensitive match, raises on not found or multiple matches)create_label,list_labels,get_label,delete_labelmethods_LabelResponseHandlerand_LabelListResponseHandlerqueue_nameas alternative toqueue_idlabel_nameas alternative tolabel_idcreate_scoreto acceptlabel_namefi/queues/__init__.pyAnnotationLabelfromfi.annotations.typesfi/utils/routes.pyannotations_labelsandannotations_labels_detailroutesBackward Compatibility
All existing ID-based calls work unchanged. Name params are optional keyword args.
Checklist
Related Issues
Closes #<issue_number>