Skip to content

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 2.0.253 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
credfeto merged 2 commits into from
Nov 20, 2025
Merged

[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 2.0.253 #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544a5f8
[Dependencies] Updating Meziantou.Analyzer (Code Analysis) to 2.0.253
credfeto Nov 14, 2025
0df474d
Fixed code analysis issues
credfeto Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Please ADD ALL Changes to the UNRELEASED SECTION and not a specific release
### Added
### Fixed
### Changed
- Dependencies - Updated Meziantou.Analyzer to 2.0.253
### Removed
### Deployment Changes

Expand Down
6 changes: 3 additions & 3 deletions src/FunFair.CodeAnalysis.Tests/FunFair.CodeAnalysis.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,19 @@
<ProjectReference Include="..\FunFair.CodeAnalysis\FunFair.CodeAnalysis.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Credfeto.Enumeration.Source.Generation.Attributes" Version="1.2.129.1430" />
<PackageReference Include="Credfeto.Enumeration.Source.Generation.Attributes" Version="1.2.131.1523" />
<PackageReference Include="FunFair.Test.Common" Version="6.2.4.1830" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageReference Include="xunit.v3.mtp-v2" Version="3.2.0" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Credfeto.Enumeration.Source.Generation" Version="1.2.129.1430" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Credfeto.Enumeration.Source.Generation" Version="1.2.131.1523" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="CSharpIsNullAnalyzer" Version="0.1.593" PrivateAssets="all" ExcludeAssets="runtime" />
<PackageReference Include="DisableDateTimeNow" Version="1.0.5883.39470" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="FunFair.Test.Source.Generator" Version="6.2.4.1830" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Meziantou.Analyzer" Version="2.0.252" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Meziantou.Analyzer" Version="2.0.253" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="NSubstitute.Analyzers.CSharp" Version="1.0.17" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Nullable.Extended.Analyzer" Version="1.15.6581" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
4 changes: 2 additions & 2 deletions src/FunFair.CodeAnalysis/FunFair.CodeAnalysis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Credfeto.Enumeration.Source.Generation" Version="1.2.129.1430" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Credfeto.Enumeration.Source.Generation" Version="1.2.131.1523" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="CSharpIsNullAnalyzer" Version="0.1.593" PrivateAssets="all" ExcludeAssets="runtime" />
<PackageReference Include="DisableDateTimeNow" Version="1.0.5883.39470" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Meziantou.Analyzer" Version="2.0.252" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Meziantou.Analyzer" Version="2.0.253" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Microsoft.Sbom.Targets" Version="4.1.3" PrivateAssets="All" ExcludeAssets="runtime" Condition="$(EnableSbom)=='True'" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" PrivateAssets="All" ExcludeAssets="runtime" />
<PackageReference Include="Nullable.Extended.Analyzer" Version="1.15.6581" PrivateAssets="All" ExcludeAssets="runtime" />
Expand Down
23 changes: 16 additions & 7 deletions ...FunFair.CodeAnalysis/ProhibitedMethodWithStrictParametersInvocationDiagnosticsAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,22 @@
)
.Where(tuple => tuple.Parameter is not null)
.Select(tuple => (tuple.ParamSpec, Argument: arguments.Arguments[tuple.Parameter!.Ordinal]))
.Any(tuple =>
StringComparer.Ordinal.Equals(tuple.Argument.Expression.ToFullString(), y: tuple.ParamSpec.Value)
&& StringComparer.Ordinal.Equals(
tuple.Argument.Expression.Kind().ToString(),
y: tuple.ParamSpec.Type
)
);
.Any(IsMatchingType);
}

private static bool IsMatchingType((ParameterSpec ParamSpec, ArgumentSyntax Argument) tuple)
{
if (!StringComparer.Ordinal.Equals(tuple.Argument.Expression.ToFullString(), y: tuple.ParamSpec.Value))
{
return false;
}

if (!Enum.TryParse(tuple.ParamSpec.Type, out SyntaxKind type))

Check notice

Code scanning / Microsoft (R) Visual C# Compiler

Convert to conditional expression Note

'if' statement can be simplified
{
return false;
}

return tuple.Argument.Expression.IsKind(type);
}
}

Expand Down
Loading