Skip to content

fix: re-download cached func CLI binary if not executable #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
creydr wants to merge 1 commit into from
Closed

fix: re-download cached func CLI binary if not executable #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/utils/func.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,14 @@
versionDir := filepath.Join(projectDir, "bin", "func-cli", version)
funcBinary := filepath.Join(versionDir, "func")

// Check if already cached
if _, err := os.Stat(funcBinary); err == nil {
return funcBinary, nil
// Check if already cached and executable
if info, err := os.Stat(funcBinary); err == nil {
isExecutable := info.Mode().Perm()&0o111 != 0
if isExecutable {
return funcBinary, nil
}
// Binary exists but is not executable — remove and re-download
os.Remove(funcBinary)

Check failure on line 197 in test/utils/func.go

View workflow job for this annotation

GitHub Actions / Lint 

Error return value of `os.Remove` is not checked (errcheck)
}

// Download the version
Expand Down
Loading