feature: add onFullstoryDidStartSession lifecycle API#147
Open
RyanCommits wants to merge 1 commit intomasterfrom
Open
feature: add onFullstoryDidStartSession lifecycle API#147RyanCommits wants to merge 1 commit intomasterfrom
RyanCommits wants to merge 1 commit intomasterfrom
Conversation
RyanCommits
commented
Feb 25, 2026
| - (instancetype)init { | ||
| self = [super init]; | ||
| if (self) { | ||
| FS.delegate = self; |
Contributor
Author
There was a problem hiding this comment.
We now set the delegate on app start, whereas before we set it when we call onReady
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FE-466
With the Guides & Services work, it revealed a requirement to tap into these native callback APIs: iOS & Android . The requirement is that on React Native, we should be able to react when a session splits or resumes. Right now we have an
onReadyAPI that accepts one-off promises that get resolved when a session starts.Changes
FullStory.onReady().then()API deletes the previous. We now store multipleonReadypromises in an array to allow multipleFullStory.onReady().then()calls.This API maps to
onReadyandfullstoryDidStartSessionon Android and iOS, respectively. IfrecordOnStartistrue, it is likely that the session will already have started beforeonFullstoryDidStartSessionis registered on the JavaScript side. Therefore will only respond to subsequent session starts. Users will have to continue to leverage the ononReadyAPI to capture a session that is already in progress.Tested on RN 66 & 84.