fix(persistence): Fix Identity DbContext Interceptor Loop & Universal Auditing#1223
Open
cesarcastrocuba wants to merge 1 commit intofullstackhero:developfrom
Open
Conversation
…ursion guard - Implemented AuditableEntitySaveChangesInterceptor to handle IAuditableEntity and ISoftDeletable. - Added a recursion guard using [ThreadStatic] bool _isSaving to prevent StackOverflowException. - Registered the interceptor globally in PersistenceExtensions. - Registered TimeProvider.System as a singleton service. - Registered DomainEventsInterceptor in PersistenceExtensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Fix]: Fix Identity DbContext Interceptor Loop & Universal Auditing
Description
This PR addresses the
StackOverflowExceptionreported in Issue #15 by implementing a centralized audit interceptor in the Building Blocks. It includes a robust recursion guard to prevent infinite loops during the SaveChanges pipeline.Key Changes
BuildingBlocks/Persistence. This interceptor automates:CreatedOnUtc,CreatedBy,LastModifiedOnUtc, andLastModifiedByfor entities implementingIAuditableEntity.[ThreadStatic]flag to detect nested SaveChanges calls, effectively preventing stack overflow errors.DomainEventsInterceptor) globally for any DbContext using the AddHeroDbContext extension.Benefits
Verification
dotnet buildcompleted successfully (0 errors).dotnet testverified forGeneric.Tests(43 passing tests).