Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using FSH.Framework.Shared.Constants;
using FSH.Framework.Shared.Constants;
using System.Security.Claims;

namespace FSH.Framework.Shared.Identity.Claims;
Expand Down Expand Up @@ -31,7 +31,9 @@ public static class ClaimsPrincipalExtensions

// Retrieves the user's ID
public static string? GetUserId(this ClaimsPrincipal principal) =>
principal?.FindFirstValue(ClaimTypes.NameIdentifier);
principal?.FindFirstValue("uid")
?? principal?.FindFirstValue("sub")
?? principal?.FindFirstValue(ClaimTypes.NameIdentifier);

// Retrieves the user's image URL as Uri
public static Uri? GetImageUrl(this ClaimsPrincipal principal)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using FSH.Framework.Core.Exceptions;
using FSH.Framework.Core.Exceptions;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Configuration;
Expand Down Expand Up @@ -41,6 +41,7 @@ public void Configure(string? name, JwtBearerOptions options)

options.RequireHttpsMetadata = true;
options.SaveToken = false;
options.MapInboundClaims = false;
options.TokenValidationParameters = new TokenValidationParameters
{
ValidateIssuerSigningKey = true,
Expand Down
68 changes: 68 additions & 0 deletions src/Tests/Generic.Tests/Identity/ClaimsPrincipalExtensionsTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
using System.Security.Claims;
using FSH.Framework.Shared.Identity.Claims;
using Xunit;

namespace Generic.Tests.Identity;

public class ClaimsPrincipalExtensionsTests
{
[Fact]
public void GetUserId_Should_ReturnUidClaim_WhenPresent()
{
// Arrange
var claims = new List<Claim> { new Claim("uid", "user-123") };
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));

// Act
var userId = principal.GetUserId();

// Assert
Assert.Equal("user-123", userId);
}

[Fact]
public void GetUserId_Should_ReturnSubClaim_WhenUidIsMissing()
{
// Arrange
var claims = new List<Claim> { new Claim("sub", "user-456") };
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));

// Act
var userId = principal.GetUserId();

// Assert
Assert.Equal("user-456", userId);
}

[Fact]
public void GetUserId_Should_ReturnNameIdentifier_WhenUidAndSubAreMissing()
{
// Arrange
var claims = new List<Claim> { new Claim(ClaimTypes.NameIdentifier, "user-789") };
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));

// Act
var userId = principal.GetUserId();

// Assert
Assert.Equal("user-789", userId);
}

[Fact]
public void GetUserId_Should_PrioritizeUidOverSub()
{
// Arrange
var claims = new List<Claim>
{
new Claim("uid", "priority-uid"),
new Claim("sub", "fallback-sub")
};
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));

// Act
var userId = principal.GetUserId();

// Assert
Assert.Equal("priority-uid", userId);
}
}