fix: Include TenantId and UserId in GlobalExceptionHandler Logs#1221
Open
cesarcastrocuba wants to merge 1 commit intofullstackhero:developfrom
Open
fix: Include TenantId and UserId in GlobalExceptionHandler Logs#1221cesarcastrocuba wants to merge 1 commit intofullstackhero:developfrom
cesarcastrocuba wants to merge 1 commit intofullstackhero:developfrom
Conversation
…[I-17] - Pushes tenant_id and user_id to Serilog LogContext for all exceptions- Resolves scoped services (ICurrentUser, IMultiTenantContextAccessor) from RequestServices to avoid DI scope conflicts- Added unit tests in Generic.Tests to verify context extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fix]: Include TenantId and UserId in GlobalExceptionHandler Logs
Description
This PR enhances the GlobalExceptionHandler to improve observability in multi-tenant environments. It ensures that every exception logged includes the relevant
tenant_idanduser_idcontext.Key Changes:
IMultiTenantContextAccessorand ICurrentUser dynamically fromHttpContext.RequestServices. This preventsSystem.InvalidOperationExceptionwhen a Singleton handler attempts to consume Scoped services.tenant_idanduser_idto the SerilogLogContextwhen an exception occurs.Exception at /api/endpoint (Tenant: root, User: Anonymous) - Detail...).Related Issues
Verification
Generic.TestsusingNSubstituteto verify context extraction and log enrichment.builder.Build()AggregateException is resolved.Type of Change