feat(testing): redesign testing architecture, resolve performance warnings, and update guide#1220
Open
cesarcastrocuba wants to merge 18 commits intofullstackhero:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a comprehensive restructuring of the framework's testing system, moving toward a more scalable, decoupled architecture aligned with modern .NET best practices. Additionally, it addresses multiple critical performance warnings and synchronizes the development environment's testing guide.
Key Changes:
Testing Architecture Redesign:
Architecture.Tests: Enforces layering and dependency rules.Shared.Tests: Common infrastructure and container configuration.Integration.Tests: Persistence and business logic (MediatR) testing without HTTP.Functional.Tests: End-to-End vertical slices via HTTP.Spec.Tests: BDD Acceptance specs using Gherkin.Testcontainers(PostgreSQL/Redis) to ensure environment parity and eliminate "it works on my machine" issues.NSubstitutefor cleaner syntax and improved maintainability.Performance & Code Quality:
_logger.IsEnabled(LogLevel.Information)guards across the Identity,Multitenancy, andAuditingmodules. This prevents unnecessary allocations and string concatenations when the logging level is disabled.MimeKit/MailKitto resolve vulnerabilities and improved nullability handling in mail services.Documentation & Skills Synchronization:
Multitenancy,Auditing,Generic) to ensure the AI assistant remains aware of the full test suite.Functional Verification Fixes:
JsonElementdeserialization errors during functional test execution.Verification Results: