Skip to content

Conversation

@faisne
Copy link
Contributor

@faisne faisne commented Jan 4, 2026

  • replaced <i> tags with asterisks around commands, table names, etc, for consistency with other parts
  • fixed small gramatical or translation errors
  • improved formatting in code blocks

@vejol vejol added the part 13 label Jan 11, 2026
@vejol
Copy link
Contributor

vejol commented Jan 11, 2026

Thanks for the pull request!

Unfortunately, it contains some unwanted and unnecessary changes, so I won’t approve it as-is.

In the course material, the <i> tag is used to produce italic text, for example to emphasize file names and new terms. The symbols * and _ around a word make the word monospace-styled, which works well for anything that refers to code, such as variable and function names. Unfortunately, this styling hasn’t been used completely consistently everywhere in the course material, but we should still aim for it.

Here is an example that shows both styles:

image

It is not appropriate to replace all <i> tags with the * symbol, because they serve different purposes. There is also no need to replace _ characters with * symbols, because they do the same thing.

Can I ask you to update this pull request so that it follows these principles? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants