chore(#1805): replace hardcoded model enums with authoritative refs#1806
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
chore(#1805): replace hardcoded model enums with authoritative refs#1806fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The pr-review SKILL.md hardcoded specific model names (opus, sonnet, haiku, claude-sonnet-4-6) when describing valid values for the Agent tool's model parameter. When upstream tool schemas expanded, these hardcoded lists became stale and caused false positive api-contract findings in review runs. Replace the two prose sections that enumerate model names with generic references to the Agent tool's model parameter definition. The sub-agent table still shows current frontmatter values (which is factual usage, not an exhaustive valid-value list). The sub-agent frontmatter files themselves are unchanged since they contain actual configuration, not documentation of allowed values. Note: make lint could not run due to sandbox Go toolchain permission issue (unrelated to this change). This is a docs-only change with no Go code modifications. Closes #1805
Site previewPreview: https://ef83d186-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Two sonnet-tier sub-agents (style-conventions, intent-coherence) could not be dispatched due to model availability on the current Vertex deployment. These are informational gaps only — the correctness sub-agent (opus-tier) completed successfully with no findings, and this is a minimal docs-only change (4 additions, 5 deletions in a single Markdown file) that replaces hardcoded model name enumerations with generic references to the Agent tool's model parameter definition. The change is well-scoped to the linked issue (#1805) and touches no protected paths. |
rh-hemartin
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr-review SKILL.md hardcoded specific model names (opus, sonnet, haiku, claude-sonnet-4-6) when describing valid values for the Agent tool's model parameter. When upstream tool schemas expanded, these hardcoded lists became stale and caused false positive api-contract findings in review runs.
Replace the two prose sections that enumerate model names with generic references to the Agent tool's model parameter definition. The sub-agent table still shows current frontmatter values (which is factual usage, not an exhaustive valid-value list). The sub-agent frontmatter files themselves are unchanged since they contain actual configuration, not documentation of allowed values.
Note: make lint could not run due to sandbox Go toolchain permission issue (unrelated to this change). This is a docs-only change with no Go code modifications.
Closes #1805
Post-script verification
agent/1805-remove-hardcoded-model-enums)de4ce7110e460377f26ea2ed285d5e8c3f4a560f..HEAD)