Skip to content

fix(dispatch): map fix stage to coder role in per-org scaffold#1796

Open
waynesun09 wants to merge 1 commit into
mainfrom
fix-dispatch-role-mapping
Open

fix(dispatch): map fix stage to coder role in per-org scaffold#1796
waynesun09 wants to merge 1 commit into
mainfrom
fix-dispatch-role-mapping

Conversation

@waynesun09
Copy link
Copy Markdown
Contributor

@waynesun09 waynesun09 commented Jun 2, 2026

Summary

The per-org scaffold dispatch.yml is missing the fix→coder role mapping that reusable-dispatch.yml already has. This causes /fs-fix to be silently skipped on all per-org installations:

Stage 'fix' skipped — role 'fix' not in defaults.roles

Root cause

Commit 709d8af0 correctly added code|fix) STAGE_ROLE="coder" to the scaffold dispatch on main. However, the merge of PR #1022 (c7c57170) resolved a conflict in the case statement using the branch version that lacked the fix mapping, regressing the fix.

The per-repo path (reusable-dispatch.yml:267) was fixed separately in commit 005ac0a1 and survived the merge. Only per-org installations are affected.

Change

One-line fix: add fix to the existing code) case in the stage-to-role mapping at internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml:274:

# Before:
code) STAGE_ROLE="coder" ;;

# After:
code|fix) STAGE_ROLE="coder" ;;

This aligns with the per-repo dispatch and with reusable-fix.yml, which already mints a coder token (role: coder).

Test plan

  • Trigger /fs-fix on a per-org repo whose config.yaml has default roles (no fix entry) — dispatch should route to fix stage instead of skipping
  • Confirm code, retro, and prioritize stage mappings are unaffected

Superseded by #1611

Note: PR #1611 (ADR 41 — synchronous workflow_call dispatch refactor) includes this same fix as part of a larger architectural change that replaces the entire dispatch mechanism. If #1611 merges first, this PR can be closed as superseded. This PR exists as the minimal surgical fix in case #1611 needs more review time.

Partially addresses #1725
Related: #1186 (closed prematurely — only per-repo path was fixed by #1187)

The per-org scaffold dispatch.yml was missing the fix→coder role
mapping that reusable-dispatch.yml already has. This caused /fs-fix
to be silently skipped on all per-org installations with the notice:
"Stage 'fix' skipped — role 'fix' not in defaults.roles"

The fix stage reuses the coder app (reusable-fix.yml mints a coder
token), so it should map to the coder role in the stage-to-role
check — matching the per-repo dispatch at reusable-dispatch.yml:267.

Root cause: commit 709d8af added code|fix on main, but the merge
of PR #1022 (c7c5717) resolved a conflict in the case statement
using the branch version that lacked the fix mapping.

Partially addresses #1725

Signed-off-by: Wayne Sun <gsun@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Site preview

Preview: https://086f3ea6-site.fullsend-ai.workers.dev

Commit: 430cbb5a302d04f153683af5d356e1672beffa81

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

Info

  • [sub-agent-failure] N/A — The intent-coherence sub-agent did not return findings: model claude-sonnet-4-5@20250929 not available on vertex deployment.
  • [sub-agent-failure] N/A — The style-conventions sub-agent did not return findings: model claude-sonnet-4-5@20250929 not available on vertex deployment.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 2, 2026
@waynesun09
Copy link
Copy Markdown
Contributor Author

This fix is also included in #1611 (ADR 41 — synchronous workflow_call dispatch refactor) at dispatch.yml:237, which rewrites the entire dispatch mechanism and eliminates the thin stage workflow scanning pattern. If #1611 merges first, this PR can be closed as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants