fix(dispatch): map fix stage to coder role in per-org scaffold#1796
Open
waynesun09 wants to merge 1 commit into
Open
fix(dispatch): map fix stage to coder role in per-org scaffold#1796waynesun09 wants to merge 1 commit into
waynesun09 wants to merge 1 commit into
Conversation
The per-org scaffold dispatch.yml was missing the fix→coder role mapping that reusable-dispatch.yml already has. This caused /fs-fix to be silently skipped on all per-org installations with the notice: "Stage 'fix' skipped — role 'fix' not in defaults.roles" The fix stage reuses the coder app (reusable-fix.yml mints a coder token), so it should map to the coder role in the stage-to-role check — matching the per-repo dispatch at reusable-dispatch.yml:267. Root cause: commit 709d8af added code|fix on main, but the merge of PR #1022 (c7c5717) resolved a conflict in the case statement using the branch version that lacked the fix mapping. Partially addresses #1725 Signed-off-by: Wayne Sun <gsun@redhat.com>
Site previewPreview: https://086f3ea6-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsInfo
|
Contributor
Author
rh-hemartin
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The per-org scaffold
dispatch.ymlis missing thefix→coderrole mapping thatreusable-dispatch.ymlalready has. This causes/fs-fixto be silently skipped on all per-org installations:Root cause
Commit
709d8af0correctly addedcode|fix) STAGE_ROLE="coder"to the scaffold dispatch on main. However, the merge of PR #1022 (c7c57170) resolved a conflict in the case statement using the branch version that lacked thefixmapping, regressing the fix.The per-repo path (
reusable-dispatch.yml:267) was fixed separately in commit005ac0a1and survived the merge. Only per-org installations are affected.Change
One-line fix: add
fixto the existingcode)case in the stage-to-role mapping atinternal/scaffold/fullsend-repo/.github/workflows/dispatch.yml:274:This aligns with the per-repo dispatch and with
reusable-fix.yml, which already mints a coder token (role: coder).Test plan
/fs-fixon a per-org repo whoseconfig.yamlhas default roles (nofixentry) — dispatch should route to fix stage instead of skippingcode,retro, andprioritizestage mappings are unaffectedSuperseded by #1611
Note: PR #1611 (ADR 41 — synchronous
workflow_calldispatch refactor) includes this same fix as part of a larger architectural change that replaces the entire dispatch mechanism. If #1611 merges first, this PR can be closed as superseded. This PR exists as the minimal surgical fix in case #1611 needs more review time.Partially addresses #1725
Related: #1186 (closed prematurely — only per-repo path was fixed by #1187)